Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127793810. |
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59531 Only clear matching `fontVariationSettings` before reapplying them when the effective typeface has changed. Changed settings already bypass the platform equality shortcut, and an unchanged typeface does not need to be replaced on `Paint`. Preserve `TextView` typeface bookkeeping and compare its effective typeface after the setter. If the platform rejects unsupported axes, explicitly clear previous settings rather than retaining stale axes. Changelog: [Android][Fixed] - Avoid unnecessary font variation resets while preserving correct text measurement. Differential Revision: D127793810
javache
force-pushed
the
export-D127793810
branch
from
October 27, 2026 12:52
1d86f3a to
24b09f0
Compare
meta-codesync
Bot
changed the title
Visual regressionNo visual differences at ios: no capture |
Summary: Only clear matching `fontVariationSettings` before reapplying them when the effective typeface has changed. Changed settings already bypass the platform equality shortcut, and an unchanged typeface does not need to be replaced on `Paint`. Preserve `TextView` typeface bookkeeping and compare its effective typeface after the setter. If the platform rejects unsupported axes, explicitly clear previous settings rather than retaining stale axes. Changelog: [Android][Fixed] - Avoid unnecessary font variation resets while preserving correct text measurement. Differential Revision: D127793810
javache
force-pushed
the
export-D127793810
branch
from
October 30, 2026 10:11
24b09f0 to
e2ccb35
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Only clear matching
fontVariationSettingsbefore reapplying them when the effective typeface has changed. Changed settings already bypass the platform equality shortcut, and an unchanged typeface does not need to be replaced onPaint.Preserve
TextViewtypeface bookkeeping and compare its effective typeface after the setter. If the platform rejects unsupported axes, explicitly clear previous settings rather than retaining stale axes.Changelog:
[Android][Fixed] - Avoid unnecessary font variation resets while preserving correct text measurement.
Differential Revision: D127793810