Repository navigation
Report keyboard show notifications with an empty frame as hide events (#59559) - #59559
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@ybcd00 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127272268. |
meta-codesync
Bot
changed the title
ybcd00
added a commit
to ybcd00/react-native
that referenced
this pull request
Oct 27, 2026
…react#59559) Summary: When a foldable iPhone is folded, unfolded or rotated, iOS can send a "keyboard will show" notification for a keyboard with zero height while no text field is focused. `RCTKeyboardObserver` passed it to JS as a show, so screens acted as if a keyboard were open: inputs stayed in their keyboard-up position and some pages went blank. Now a zero-height show with no focused text field is sent as a hide. Everything else is unchanged, including hardware keyboards on iPad, which send zero-height shows while a field is focused. Changelog: [iOS][Fixed] - Report zero-height keyboard show notifications with no focused text field as `keyboardWillHide`/`keyboardDidHide` Reviewed By: cipolleschi Differential Revision: D127272268
ybcd00
force-pushed
the
export-D127272268
branch
from
October 27, 2026 23:56
2048ff4 to
7a1cbd0
Compare
ybcd00
added a commit
to ybcd00/react-native
that referenced
this pull request
Oct 28, 2026
…react#59559) Summary: When a foldable iPhone is folded, unfolded or rotated, iOS can send a "keyboard will show" notification for a keyboard with zero height while no text field is focused. `RCTKeyboardObserver` passed it to JS as a show, so screens acted as if a keyboard were open: inputs stayed in their keyboard-up position and some pages went blank. Now a zero-height show with no focused text field is sent as a hide. Everything else is unchanged, including hardware keyboards on iPad, which send zero-height shows while a field is focused. Changelog: [iOS][Fixed] - Report zero-height keyboard show notifications with no focused text field as `keyboardWillHide`/`keyboardDidHide` Reviewed By: cipolleschi Differential Revision: D127272268
ybcd00
force-pushed
the
export-D127272268
branch
from
October 28, 2026 00:19
7a1cbd0 to
5211d97
Compare
…react#59559) Summary: When a foldable iPhone is folded, unfolded or rotated, iOS can send a "keyboard will show" notification for a keyboard with zero height while no text field is focused. `RCTKeyboardObserver` passed it to JS as a show, so screens acted as if a keyboard were open: inputs stayed in their keyboard-up position and some pages went blank. Now a zero-height show with no focused text field is sent as a hide. Everything else is unchanged, including hardware keyboards on iPad, which send zero-height shows while a field is focused. Changelog: [iOS][Fixed] - Report zero-height keyboard show notifications with no focused text field as `keyboardWillHide`/`keyboardDidHide` Reviewed By: cipolleschi Differential Revision: D127272268
ybcd00
force-pushed
the
export-D127272268
branch
from
October 28, 2026 01:52
5211d97 to
9634628
Compare
Abbondanzo
approved these changes
Oct 28, 2026
Collaborator
|
This pull request was successfully merged by @ybcd00 in c99947e When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When a foldable iPhone is folded, unfolded or rotated, iOS can send a "keyboard will show" notification for a keyboard with zero height while no text field is focused.
RCTKeyboardObserverpassed it to JS as a show, so screens acted as if a keyboard were open: inputs stayed in their keyboard-up position and some pages went blank.Now a zero-height show with no focused text field is sent as a hide. Everything else is unchanged, including hardware keyboards on iPad, which send zero-height shows while a field is focused.
Changelog:
[iOS][Fixed] - Report zero-height keyboard show notifications with no focused text field as
keyboardWillHide/keyboardDidHideReviewed By: cipolleschi
Differential Revision: D127272268