Skip to content

perf(virtualized-lists): use a Set for stale-index lookup in ViewabilityHelper #59590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seyedmostafahasani wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

perf(virtualized-lists): use a Set for stale-index lookup in ViewabilityHelper #59590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/virtualized-lists/Lists/ViewabilityHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,10 @@ class ViewabilityHelper {
) => ViewToken,
) {
// Filter out indices that have gone out of view since this call was scheduled.
// Use a Set so the lookup is O(1) per index instead of O(n) (`includes`).
const currentViewableIndices = new Set(this._viewableIndices);
viewableIndicesToCheck = viewableIndicesToCheck.filter(ii =>
this._viewableIndices.includes(ii),
currentViewableIndices.has(ii),
);
const prevItems = this._viewableItems;
const nextItems = new Map(
Expand Down
Loading