Repository navigation
Bump Electron to 43.8.3 - #59594
Open
christophpurrer wants to merge 1 commit into
Open
Bump Electron to 43.8.3#59594christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
Summary: This diff moves Electron from 43.0.0 to 43.8.3. Electron 43.0.0 is in the affected range for CVE-2026-115570. The 43 line is fixed from 43.8.1 (T294720216). Changelog: [Internal] The `xplat/js/tools/electron` shim and the `electron` pin in `debugger-shell` must stay on the same version. In the xplat/js workspace, the pin is what links `debugger-shell` to the shim. If only the shim moves, yarn looks for npm `electron@43.0.0`, which is not in `xplat/js/yarn.lock`, and frozen installs fail. NimbleRecorder (`NR_HTML`) also uses this shim. The next diff in the stack refreshes its lockfile. Command run: ``` js1 upgrade electron --version 43.8.3 --no-ephemeral ``` The devserver that ran the command cannot reach GitHub. So `electron/get` read the release files from a local mirror (`ELECTRON_MIRROR=http://127.0.0.1:18743/`). The mirror held the 5 official zips and the official `SHASUMS256.txt`, and `electron/get` checked each zip against it. The darwin-x64, darwin-arm64, linux-x64, and win32-x64 zips come from `arvr/js/third-party/electron`. The diff author downloaded the linux-arm64 zip from the GitHub release. All 5 SHA-256 values match `SHASUMS256.txt-43.8.3` and the `checksums.json` in the npm package. Differential Revision: D128177919
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128177919. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff moves Electron from 43.0.0 to 43.8.3. Electron 43.0.0 is in the affected range for CVE-2026-115570. The 43 line is fixed from 43.8.1 (T294720216).
Changelog: [Internal]
The
xplat/js/tools/electronshim and theelectronpin indebugger-shellmust stay on the same version. In the xplat/js workspace, the pin is what linksdebugger-shellto the shim. If only the shim moves, yarn looks for npmelectron@43.0.0, which is not inxplat/js/yarn.lock, and frozen installs fail.NimbleRecorder (
NR_HTML) also uses this shim. The next diff in the stack refreshes its lockfile.Command run:
The devserver that ran the command cannot reach GitHub. So
electron/getread the release files from a local mirror (ELECTRON_MIRROR=http://127.0.0.1:18743/). The mirror held the 5 official zips and the officialSHASUMS256.txt, andelectron/getchecked each zip against it. The darwin-x64, darwin-arm64, linux-x64, and win32-x64 zips come fromarvr/js/third-party/electron. The diff author downloaded the linux-arm64 zip from the GitHub release. All 5 SHA-256 values matchSHASUMS256.txt-43.8.3and thechecksums.jsonin the npm package.Differential Revision: D128177919