Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128312388. |
Visual regression1 visual difference(s) at ios
|
| Expected | Captured |
|---|---|
 |
 |
meta-codesync
Bot
changed the title
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 29, 2026
Summary: Avoid initialising the native object twice when constructing `WritableNativeMap` from C++. Give `newObjectCxxArgs` a no-init Java constructor path while preserving the normal empty-map Java constructor. Build touch-event payloads as complete `folly::dynamic` maps and pass them to that factory, instead of populating writable maps and arrays field by field. The payload shape, value types and writable event APIs remain unchanged. Changelog: [Android][Fixed] - Allow `WritableNativeMap` construction from C++ without double initialisation. [Android][Changed] - Construct writable touch-event payloads directly in C++. Differential Revision: D128312388
javache
force-pushed
the
export-D128312388
branch
from
October 29, 2026 14:48
a8aa5ad to
b217562
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 29, 2026
Summary: Avoid initialising the native object twice when constructing `WritableNativeMap` from C++. Give `newObjectCxxArgs` a no-init Java constructor path while preserving the normal empty-map Java constructor. Build touch-event payloads as complete `folly::dynamic` maps and pass them to that factory, instead of populating writable maps and arrays field by field. The payload shape, value types and writable event APIs remain unchanged. Changelog: [Android][Fixed] - Allow `WritableNativeMap` construction from C++ without double initialisation. [Android][Changed] - Construct writable touch-event payloads directly in C++. Differential Revision: D128312388
javache
force-pushed
the
export-D128312388
branch
from
October 29, 2026 14:58
b217562 to
231da56
Compare
Summary: Pull Request resolved: react#59618 Avoid initialising the native object twice when constructing `WritableNativeMap` from C++. Give `newObjectCxxArgs` a no-init Java constructor path while preserving the normal empty-map Java constructor. Build touch-event payloads as complete `folly::dynamic` maps and pass them to that factory, instead of populating writable maps and arrays field by field. The payload shape, value types and writable event APIs remain unchanged. Changelog: [Android][Fixed] - Allow `WritableNativeMap` construction from C++ without double initialisation. [Android][Changed] - Construct writable touch-event payloads directly in C++. Differential Revision: D128312388
javache
force-pushed
the
export-D128312388
branch
from
October 29, 2026 16:19
231da56 to
61b692c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Avoid initialising the native object twice when constructing
WritableNativeMapfrom C++. GivenewObjectCxxArgsa no-init Java constructor path while preserving the normal empty-map Java constructor.Build touch-event payloads as complete
folly::dynamicmaps and pass them to that factory, instead of populating writable maps and arrays field by field. The payload shape, value types and writable event APIs remain unchanged.Changelog:
[Android][Fixed] - Allow
WritableNativeMapconstruction from C++ without double initialisation.[Android][Changed] - Construct writable touch-event payloads directly in C++.
Differential Revision: D128312388