Repository navigation
Bump nlohmann_json to 3.12.0 so Fantom's tester builds with newer Clang - #59675
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
Contributor
Author
|
The ios-simulator Debug slice failed before the build started: the runner could not resolve actions/setup-node@v6. This change does not cause it. |
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D128596399. |
cipolleschi
approved these changes
Oct 30, 2026
Contributor
|
@lazerg could you rebase on top of main? |
lazerg
force-pushed
the
fix/issue-59667-nlohmann-json-3.12
branch
from
October 30, 2026 16:09
e41178d to
711aeb6
Compare
Contributor
Author
|
Rebased on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fantom's tester builds with
-Wall -Werror, and nlohmann_json 3.11.2 declares its literal operators asoperator "" _json. Newer Clang flags the space before the suffix with-Wdeprecated-literal-operator, so the build stops injson.hpp. nlohmann_json 3.12.0 writes them asoperator""_json, so this bumps the pinned version. Fantom is the only consumer of this version entry.Fixes #59667
Changelog:
[INTERNAL] [FIXED] - Bump nlohmann_json to 3.12.0 so Fantom's tester builds with newer Clang
Test Plan:
Compiled a file that includes
<nlohmann/json.hpp>withclang++ -std=c++20 -Wall -Werror(Apple clang 21). Against 3.11.2 it fails with the four-Wdeprecated-literal-operatorerrors from the issue; against 3.12.0 it builds. Also built and ran theparse/is_discarded/operator[]callsPackagerConnection.cppmakes against 3.12.0 with the same flags.