Skip to content

Zero-initialize generated array-enum mask wrappers in codegen #59703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsusul wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Zero-initialize generated array-enum mask wrappers in codegen #59703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbc81cf
Expect generated array-enum mask wrappers to zero-initialize their value
hsusul Oct 30, 2026
9d847fc
Zero-initialize generated array-enum mask wrappers
hsusul Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e-codegen/e2e/deep_imports/__tests__/components/__snapshots__/GeneratePropsH-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace facebook::react {
using ArrayPropsNativeComponentViewSizesMask = uint32_t;

struct ArrayPropsNativeComponentViewSizesMaskWrapped {
ArrayPropsNativeComponentViewSizesMask value;
ArrayPropsNativeComponentViewSizesMask value{};
};

enum class ArrayPropsNativeComponentViewSizes: ArrayPropsNativeComponentViewSizesMask {
Expand Down
2 changes: 1 addition & 1 deletion ...ive-codegen/e2e/namespaced/__tests__/components/__snapshots__/GeneratePropsH-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace facebook::react {
using ArrayPropsNativeComponentViewSizesMask = uint32_t;

struct ArrayPropsNativeComponentViewSizesMaskWrapped {
ArrayPropsNativeComponentViewSizesMask value;
ArrayPropsNativeComponentViewSizesMask value{};
};

enum class ArrayPropsNativeComponentViewSizes: ArrayPropsNativeComponentViewSizesMask {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-codegen/src/generators/components/GeneratePropsH.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ const ArrayEnumTemplate = ({
using ${enumMask} = uint32_t;

struct ${enumMask}Wrapped {
${enumMask} value;
${enumMask} value{};
};

enum class ${enumName}: ${enumMask} {
Expand Down
6 changes: 3 additions & 3 deletions ...ive-codegen/src/generators/components/__tests__/__snapshots__/GeneratePropsH-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,7 +1162,7 @@ namespace facebook::react {
using ArrayPropsNativeComponentSizesMask = uint32_t;

struct ArrayPropsNativeComponentSizesMaskWrapped {
ArrayPropsNativeComponentSizesMask value;
ArrayPropsNativeComponentSizesMask value{};
};

enum class ArrayPropsNativeComponentSizes: ArrayPropsNativeComponentSizesMask {
Expand Down Expand Up @@ -1764,7 +1764,7 @@ namespace facebook::react {
using ArrayPropsWithOptionalGenNativeComponentSizesMask = uint32_t;

struct ArrayPropsWithOptionalGenNativeComponentSizesMaskWrapped {
ArrayPropsWithOptionalGenNativeComponentSizesMask value;
ArrayPropsWithOptionalGenNativeComponentSizesMask value{};
};

enum class ArrayPropsWithOptionalGenNativeComponentSizes: ArrayPropsWithOptionalGenNativeComponentSizesMask {
Expand Down Expand Up @@ -2060,7 +2060,7 @@ namespace facebook::react {
using ArrayPropsWithOptionalObjectGenNativeComponentSizesMask = uint32_t;

struct ArrayPropsWithOptionalObjectGenNativeComponentSizesMaskWrapped {
ArrayPropsWithOptionalObjectGenNativeComponentSizesMask value;
ArrayPropsWithOptionalObjectGenNativeComponentSizesMask value{};
};

enum class ArrayPropsWithOptionalObjectGenNativeComponentSizes: ArrayPropsWithOptionalObjectGenNativeComponentSizesMask {
Expand Down
Loading