Accessibility deserialize fixes - #254
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes include regression coverage and coordinated package updates with no unresolved blocking issues.
Pull request overview
Fixes accessibility metadata deserialization for scalar and array values, with regression tests and coordinated package releases.
Changes:
- Normalize accessibility metadata inputs.
- Add regression coverage for valid and malformed values.
- Bump package versions and update changelogs.
File summaries
| File | Description |
|---|---|
shared/test/accessibility/Localization.test.ts |
Suppresses expected warnings during tests. |
shared/test/accessibility/Accessibility.test.ts |
Adds deserialization regression tests. |
shared/src/publication/accessibility/Accessibility.ts |
Normalizes accessibility metadata fields. |
shared/package.json |
Bumps shared package version. |
shared/CHANGELOG.MD |
Documents the fix. |
navigator/package.json |
Bumps navigator version. |
navigator/CHANGELOG.MD |
Documents republishing. |
navigator-html-injectables/package.json |
Bumps package version. |
navigator-html-injectables/CHANGELOG.MD |
Documents republishing. |
decorator/package.json |
Bumps decorator version. |
decorator/CHANGELOG.MD |
Documents republishing. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects the deserialization of accessibility metadata.
Closes #253