mempool: start after a torn sidecar - #914
Merged
Merged
Conversation
A hard stop during the 5s persist could leave LIVE slots naming body bytes that never reached disk. Open mapped that to a configuration error, so a restart loop never came back. Sync the body before those slots and the slots before meta. Keep an in-range prefix. Move an unreadable image aside and start empty.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #859
A hard stop during the 5-second mempool persist could leave
slotsnamingtx.bodybytes that were not durable. Startup treated that as a configuration error and a supervisor restarted forever.persist_dueand shutdownflushnowsync_datathe body before publishingLIVEslots, then sync slots beforemeta. Open keeps transactions still inside the logical body and drops the tail. An unreadable sidecar (bad magic, unknown schema, or an in-range payload whose txid does not match the slot) is moved undermempool/torn-<unix>/and the node starts empty.fee_historystays put. A real IO failure still fails the open.The beats are on
analog_milestone_and_mempool_persist.