Repository navigation
test: shorter index, resume, sv2, and mempool pads - #915
Merged
Merged
Conversation
The released-index journey slept PROGRESS_EVERY plus two seconds, so the consensus lib waited out the operator's 10s cadence. Production still passes that constant. The journey holds one second and pins the constant at 10s, so a hardcoded 10s comparison or a changed literal fails.
The most-work resume journey inserted 12,000 headers to prove the walk does not overflow, then asked for 32. The walk is a heap stack, so the band is 256 headers scored on a 32 KiB thread: long enough that a recursive walk of it does not fit, and still past the 32-cap.
Listener checks share one stale regtest hub. The write-deadline pin is process-wide, so that chapter runs after the other accepts, and a stall of two seconds or more fails. Template and IBD chapters copy one 3-coinbase pad instead of connecting a hundred blocks each. The custom pow-limit chapter still builds its own chain.
Thirteen mempool chapters each connected a hundred-block pad. They now share one 3-coinbase chain and open a fresh mempool directory. The 257-coinbase scan and the height-5 fee-history tests keep their own pads. The snapshot refresh still waits out its interval, and the chapter that connects a block runs last.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No operator-facing change.
Tests
Local debug
--libon this VM: the index journey no longer sleeps 12s; the resume journey finishes in 0.11s; sv2 is 13 tests in 6.02s against 20 tests in 23.58s on the previous suite; net is 638 tests, with the shared pad journey at 2.86s.