ci: publish per-crate line counts on the coverage badge - #917
Merged
Merged
Conversation
The Shields badge stays the workspace total. The same JSON now lists each production crate from the filtered LCOV, and the coverage job fails when those rows do not add up to the badge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Shields badge stays the workspace total.
badges/coverage.jsonnow also lists each production crate (name,lh,lf,pct) from the same filtered LCOV the 92% gate already sums.Those rows have to add up to the badge totals, or the coverage job fails. Lines outside
crates/<name>/fail the same way. A red pull request still does not publish, andcoverage-history.jsonlstill records only the workspace total.rbitcoin.org reads this file for the security-page summary. That site change is a separate unpushed commit, not part of this pull request. Until this lands on
masterand a green coverage run publishes, the page shows the total without the crate list.