test: split journeys that are not one story - #918
Merged
Merged
Conversation
The post-pad chapters each open their own peer and do not observe each other. Prefill connects a spend of the height-1 coinbase before the high-bandwidth relay case builds its own spend of that coinbase. One OnceLock chain, a private hub per case. Genesis IBD and the synthetic header/inv case stay off that chain.
Clearnet externalip and the onion/i2p follow-up share an address book. They never read the header-dos chain.
Each sigop beat restores an empty pool. The accept-life arc spends coins those beats do not create.
Genesis rejects and the post-maturity wallet are different chains. The mature hub mines itself to height 130, inside the 121..144 window the hashps beat requires.
The catalog and the finding citations follow the new test names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Journey tests that opened one node and then ran chapters that do not observe each other are now separate named tests.
OnceLock. Each post-pad case opens a private hub on a copy, including the three that connect, mark invalid, or reorg. Genesis IBD and the synthetic header/inv case stay on their own genesis hubs, because a fresh height-102 tip is not in initial block download.mempool_accept_life. Those beats restore an empty pool. The orphan → eviction arc stays one test.rpc_regtest_from_genesiskeeps the short chain through the firstsubmitblockrejects.rpc_regtest_mature_chain_opsmines its own hub to height 130 (inside the 121..144 window) and runs the mature wallet, invalidate, and the mainnet view.No production behavior change. No changelog fragment.
Test plan
cargo test -p rbitcoin-net --lib -- announce(22 passed)cargo test -p rbitcoin-mempool --lib -- sigop_adjusted mempool_accept_life(includes both new names)cargo test -p rbitcoin-rpc --lib -- rpc_regtest_(both new names)cargo fmt --all -- --checkcargo clippy -p rbitcoin-net -p rbitcoin-mempool -p rbitcoin-rpc --all-targets -- -D warnings./scripts/ast-grep.sh