Python: reactively() yields (response, aborted) and never raises

[rileysdev]

In Python .reactively() now yield a (response, aborted) and keep reading across errors instead of raising the method's Aborted and stopping. The caller decides whether to continue, break, or raise aborted. This is the first half of making reactive reads consistent across clients (which will replace #185); the web client will follow in a separate PR, React already behaves this way.

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator (commit 9316156).

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[github-actions]

Code review

Found 2 issues. Both are Python .reactively() loops that this PR didn't update. Neither line is in the diff, so I'm posting them here rather than inline.

1. tests/reboot/reactivity_test.py still treats each item as a bare response. greeter.reactively().GetWholeState(context) now yields (response, aborted) tuples, so greeter_state.adjective raises AttributeError on the first item. That happens inside the background _do() task, so _accumulated_adjective is never set and reactivity_test_py hangs until it times out instead of failing. Fix: async for greeter_state, aborted in ..., then handle aborted before using greeter_state.

reboot/tests/reboot/reactivity_test.py

Lines 30 to 34 in 580bffa

	async def _do():
	async for greeter_state in greeter.reactively(
	).GetWholeState(context):
	self._accumulated_adjectives.append(greeter_state.adjective)
	self._accumulated_adjective.set()

2. tests/reboot/dashboard/code_watcher_tests.py _code_changes was missed. The PR updates the three Dashboard...reactively().Get loops in this file but not the OrderedMap...reactively().ReverseRange loop in _code_changes. response is now a tuple, so response.entries raises AttributeError, which breaks every test that awaits _code_changes (test_a_servicer_found_is_history, test_a_method_edited_is_history, test_a_change_made_while_the_dashboard_was_down_is_history, test_a_servicer_removed_is_history). Fix: use the same pattern as the other loops, async for response, aborted in ..., then if aborted is not None: raise aborted and assert response is not None.

reboot/tests/reboot/dashboard/code_watcher_tests.py

Lines 417 to 422 in 580bffa

	context = self.rbt.create_external_context(name=self.id())
	async for response in OrderedMap.ref(CHANGELOG_ID).reactively(
	).ReverseRange(context, limit=100):
	changes = [
	Change.FromString(entry.bytes) for entry in response.entries
	]

🤖 Generated with Claude Code

[aviator-app]

This pull request failed to merge: PR has a blocked label, remove to re-queue. After you have resolved the problem, you should remove the blocked pull request label from this PR and then try to re-queue the PR.