Skip to content

Main gets a replay-oracle note without the done merge step and with SAV-2.6's main commit - #47

Merged
redcode9 merged 1 commit into
features/state-of-the-art-development/mainfrom
features/state-of-the-art-development/wip/replay-oracle
Nov 17, 2026
Merged

redcode9 merged 1 commit into
features/state-of-the-art-development/mainfrom
features/state-of-the-art-development/wip/replay-oracle

Conversation

@redcode9

@redcode9 redcode9 commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Audit follow-up for wip/replay-oracle, after the review-fix round reached main as 6afd012. The branch was fast-forwarded to main 6afd012 first, so this PR holds one docs-only commit, in docs/wip/replay-oracle.md.

What was wrong and what changed:

  • The header still told the next merge how to resolve input.c and tests/test_input_shortcuts.py against wip/ui-foundation. That merge is done (41ff89a, in main since 0876db9), so the instruction is removed.
  • ENG-6.3 cited b5cffbf as SAV-2.6's commit in main. b5cffbf is a later main tip ("Main includes the ROM link check fix"), not the commit that brought SAV-2.6: its code, 795b98d, came in with dbab178 ("Main includes the GBA test ROMs"). The note now cites dbab178, as the other lines cite the main commit that brought each piece.

Tickets whose status changed: none.

Tests on this host:

  • git diff --check 6afd012..HEAD: clean.
  • scripts/check-tree.sh, run from a copy with CRs stripped and PYTHON=python: passes.
  • Docs only: nothing to compile, no unit test applies. CI runs make check, make test-sanitize, make check-cbmc and both PSP builds on this PR.

Files of other branches touched (rule 5): none.

@redcode9
redcode9 merged commit 223e914 into features/state-of-the-art-development/main Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant