Repository navigation
Fix bugs and incorrect metadata before release - #89
Merged
Merged
Conversation
commit-data: - Fix output name mismatch: entrypoint wrote "tag_count" but action.yml declared "tags_count", so consumers got empty string action-io-generator: - Update Dockerfile from EOL node:16-alpine to node:24-alpine - Fix dead $? check in entrypoint.sh — set +x reset $? to 0 before the conditional, making the error branch unreachable - Update package.json URLs from personal fork (tetchel/action-io-generator) to redhat-actions/common bundle-verifier: - Fix bundle_file description: said "directory" but code reads it as a file via fs.readFile(); remove misleading default of "dist" - Fix main field: index.js -> dist/index.js - Add "private": true to prevent accidental npm publish Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release code review found 7 issues across all three components:
Bugs fixed:
tag_countbutaction.ymldeclaredtags_count, so consumers got empty stringnode:16-alpine(EOL Sep 2023) — updated tonode:24-alpineentrypoint.shhad a dead$?check —set +xreset$?to 0 before the conditional, making the error branch unreachableMetadata fixed:
package.jsonURLs pointed to personal forktetchel/action-io-generatorinstead ofredhat-actions/commonbundle_filedescription said "directory" but code reads it as a file; removed misleading default ofdistmainfield pointed to nonexistentindex.js— corrected todist/index.js"private": trueto prevent accidental npm publishTest plan
🤖 Generated with Claude Code