Skip to content

test(version-management): add e2e integration tests for plugin check-versions and upgrade #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gashcrumb wants to merge 3 commits into
base: main
Choose a base branch
from
+500 −35
Open

test(version-management): add e2e integration tests for plugin check-versions and upgrade #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c671f10
test(version-management): add e2e integration tests for plugin check-…
gashcrumb Oct 2, 2026
9ce0e86
test(e2e): deduplicate runExpectingFailure helper in support/plugin-e…
gashcrumb Oct 2, 2026
c442487
fix(upgrade): allow lockfile mutation during install in CI environments
gashcrumb Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 1 addition & 34 deletions e2e-tests/plugin-dev.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
log,
logSection,
runCommand,
runExpectingFailure,
RunCommandOptions,
} from './support/plugin-export-build';

@fullsend-ai-review fullsend-ai-review Bot Oct 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] pattern-violation

RunCommandOptions is imported but no longer used anywhere in the file. The only consumer was the local runExpectingFailure function, which was removed and promoted to the shared support module in this PR. The stale import will produce an unused-import lint error and fail yarn lint:check in CI.

Suggested fix: Remove RunCommandOptions from the import block on line 22.

import {
Expand All @@ -33,40 +34,6 @@ const availableTools = detectAvailableComposeToolsSync();
const describeWithCompose =
availableTools.length > 0 ? describe : describe.skip;

async function runExpectingFailure(
command: string,
options: RunCommandOptions = {},
): Promise<{ stdout: string; stderr: string; message: string }> {
let succeeded = false;
let stdout = '';
let caughtError: unknown;

try {
const res = await runCommand(command, options);
succeeded = true;
stdout = res.stdout;
} catch (err: unknown) {
caughtError = err;
}

if (succeeded) {
throw new Error(
`Command expected to fail, but succeeded with output: ${stdout}`,
);
}

const e = (caughtError || {}) as {
stdout?: string;
stderr?: string;
message?: string;
};
return {
stdout: e?.stdout || '',
stderr: e?.stderr || '',
message: e?.message || '',
};
}

describe('plugin dev', () => {
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'rhdh-cli-plugin-dev-'));
const pluginDir = path.join(tmpDir, 'test-frontend-plugin');
Expand Down
Loading
Loading