Repository navigation
Swap the icon for the submit spinner on icon-only buttons - #33
Merged
Merged
Conversation
The validator prepends a spinner-border with me-2 to a form's submit button. On a .btn-icon button that shows the spinner beside the icon and adds a margin, so the spinner now replaces the icon instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RV6XWqMdQZF31RLBxt1G2B
 [Low impact] The PR appears safe to merge. SummaryUpdates
No actionable issues were found. Reviews (1) · Last reviewed commit: "Swap the icon for the submit spinner on ..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a form passes validation, the validator in
runtime.jsadds<span class="spinner-border spinner-border-sm me-2">to the start of the submit button. On an icon-only.btn-iconbutton, such as a search button with just a magnifier icon, the spinner shows up next to the icon, and itsme-2margin squeezes the square button.Change
Adds two rules to
redot.cssunder Global Styles:.btn-icon > .spinner-borderdrops the spinner's margin..btn-icon > .spinner-border ~ *hides everything after the spinner, so the spinner replaces the icon while the form submits.Buttons with text are not affected; they still show the spinner before their label.
Verification
Checked in Chromium against Tabler's
tabler.ltr.min.css. An icon button measures 34×34 both before and during submit, with only the spinner visible. A text button still shows the spinner and its label.npx prettier --checkpasses.Generated by Claude Code