Fellowships: Document opcodes and add proper responses - #467
Merged
Merged
Conversation
-Fellowships are still unimplemented, this is mostly for PacketAnalzyer, and general learning -CreateFellowship (client) & Fellowships (server) will be documented at a later date
-Document the client request to create and join Fellowships -Document and add the server rejection responses since we don't implement Fellowships yet
redstrate
reviewed
Sep 17, 2026
redstrate
reviewed
Sep 17, 2026
redstrate
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents more about the Fellowships system, and allows the player to now use the Fellowship Finder window to see a sample entry. If they attempt to join it, they'll be told they cannot join more Fellowships at the present time.
The separate Fellowships window is also now sent a blank list to inform the client they're not in any Fellowships. Attempting to create one from this window will result in the client being told that they cannot create more Fellowships at the present time.
There are still some unknowns and TODOs, but in the current state the windows now at least have basic functionality.