Skip to content

Replace Charset.defaultCharset() with StandardCharsets.UTF_8 #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimbethancourt merged 2 commits into from
Sep 5, 2026
Merged

Replace Charset.defaultCharset() with StandardCharsets.UTF_8 #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a2807e
Replace Charset.defaultCharset() with StandardCharsets.UTF_8
jimbethancourt Sep 5, 2026
debc03e
Added test to ensure only UTF-8 charaters are emitted
jimbethancourt Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions report/src/main/java/org/hjug/refactorfirst/report/ReportWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import java.io.OutputStreamWriter;
import java.nio.channels.Channels;
import java.nio.channels.SeekableByteChannel;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
import java.nio.file.DirectoryStream;
import java.nio.file.Files;
import java.nio.file.NoSuchFileException;
Expand Down Expand Up @@ -162,7 +162,7 @@ private void writeAtomicallySecure(SecureDirectoryStream<Path> directory, Path r
try {
try (SeekableByteChannel channel = directory.newByteChannel(temporaryName, options);
BufferedWriter writer = new BufferedWriter(
new OutputStreamWriter(Channels.newOutputStream(channel), Charset.defaultCharset()))) {
new OutputStreamWriter(Channels.newOutputStream(channel), StandardCharsets.UTF_8))) {
writer.write(content);
}
directory.move(temporaryName, directory, reportName);
Expand Down Expand Up @@ -218,7 +218,7 @@ public void writeAtomically(Path reportName, String content) throws IOException
try {
try (SeekableByteChannel channel = Files.newByteChannel(temporaryName, options);
BufferedWriter writer = new BufferedWriter(
new OutputStreamWriter(Channels.newOutputStream(channel), Charset.defaultCharset()))) {
new OutputStreamWriter(Channels.newOutputStream(channel), StandardCharsets.UTF_8))) {
writer.write(content);
}
// Verify temp file is not a symlink before move
Expand Down
17 changes: 17 additions & 0 deletions report/src/test/java/org/hjug/refactorfirst/report/ReportWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import java.io.File;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardWatchEventKinds;
Expand Down Expand Up @@ -279,4 +280,20 @@ void containReportDirectory_rejectsSymlinkedAncestor(@TempDir Path tempDir) thro
IllegalArgumentException.class,
() -> ReportWriter.containReportDirectory(tempDir.toFile(), "linked/site"));
}

@Test
void writeReportToDisk_emitsUtf8ForNonAsciiContent(@TempDir Path tempDir) throws IOException {
String nonAsciiContent = "café 漢字 😀";
Path outputDir = tempDir.resolve("output");
Files.createDirectories(outputDir);

ReportWriter.writeReportToDisk(outputDir.toString(), "test.html", nonAsciiContent);

Path outputFile = outputDir.resolve("test.html");
assertTrue(Files.exists(outputFile));

byte[] writtenBytes = Files.readAllBytes(outputFile);
byte[] expectedBytes = nonAsciiContent.getBytes(StandardCharsets.UTF_8);
assertArrayEquals(expectedBytes, writtenBytes, "ReportWriter must emit UTF-8 bytes");
}
}
Loading