Skip to content
This repository was archived by the owner on Jun 17, 2025. It is now read-only.
This repository was archived by the owner on Jun 17, 2025. It is now read-only.

v2 proposal #15

Description

@rentorm

Make this library simple and as pure wrapper (which it basically is), so it can support any current 3commas API methods.

This is already possible in v1.*, using following example:

const api = require('3commas-api-node')

const apiCall = new api({
  apiKey: '',
  apiSecret: ''
})

// get last 20 active deals
const showActiveDeals = async () => {
  let data = await apiCall.makeRequest(
  // method
  'GET',
  // path
  '/public/api/ver1/deals?'
  // params
  {
    limit: 20,
    scope: 'active',
  })
  console.log(data)
}

showActiveDeals()

Proposal is to remove all other functions, just leave makeRequest function and release it as v2. Update README with example usage and noting deprecated functions included in v1.*

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions