Replace swift-nio CI pipeline with request-dl/.github's swift-ci.yaml - #2
Open
o-nnerb wants to merge 4 commits into
Open
Replace swift-nio CI pipeline with request-dl/.github's swift-ci.yaml#2o-nnerb wants to merge 4 commits into
o-nnerb wants to merge 4 commits into
Conversation
Drops the dependency on apple/swift-nio's reusable workflows (unit_tests, cxx_interop, static_sdk, release_builds) and the pull_request_semver_label_checker action, in favor of the org-standard generic Swift CI workflow. Coverage upload stays disabled. Apple platform tests stay disabled until the generated Xcode scheme is validated for this package. References the request-dl/.github branch that adds release-builds/static-sdk support natively (no apple/swift-nio dependency) until that branch merges to main. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Not something we need to enforce on this fork. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Depended on the semver labels we just stopped enforcing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Linux/format/breaking-changes/release-builds/static-sdk are green on PR #2, worth checking whether the xcodebuild scheme resolves for this package too. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apple/swift-nio's reusable workflows (unit tests matrix, cxx-interop, static-sdk, release-builds) and thepull_request_semver_label_checkeraction.main.yml+pull_request.ymlwith a singleswift-ci.yamlcaller intorequest-dl/.github's generic Swift CI workflow, matching the pattern already used byrequest-dl-nio.request-dl/.github/.github/workflows/swift-ci.yaml@claude/proposal-release-builds-static-sdk-d53aed(still being tested) — needs to be bumped to@mainonce that branch merges upstream inrequest-dl/.github.pull_request_label.ymlrewritten to check the semver label natively instead of viaapple/swift-nio's composite action.enable-apple-testsstays disabled for now — the generated Xcode scheme for this package hasn't been validated against this generic workflow (unlikerequest-dl-nio, which it was built around).enable-static-sdkis on:NIOTransportServicesis platform-conditioned inPackage.swift, so it's not pulled in on Linux — should be safe.Test plan
request-dl/.githubref to@mainonce the release-builds/static-sdk branch there is mergedenable-apple-testsseparately before turning it on