Repository navigation
fix(sdk): load DTFs with legacy bytes32 token metadata (mvRWA) - #56
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
jgalat
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name()andsymbol()asbytes32, not dynamic strings.Reproduction
Production route: https://app.reserve.org/ethereum/index-dtf/0xa5cdea03b11042fc10b52af9eca48bb17a2107d2/overview/
Published SDK 0.8.1
createDtfSdk().index.get({address: '0xa5cdea03b11042fc10b52af9eca48bb17a2107d2', chainId: 1, brand: true})rejects at MKRname()withContractFunctionExecutionError/IntegerOutOfRangeError. Raw live RPC returns0x4d616b6572000000000000000000000000000000000000000000000000000000for MKR name and a bytes32 MKR symbol. The core DTF atom never populates, so the UI remains in loading placeholders despite successful API and subgraph responses.Verification
git diff --checkpass.Rollout
Merge and publish the SDK patch, then update Register's SDK dependency and deploy. mvRWA is currently marked inactive/sell-only by the existing catalog; this fix intentionally does not change that status.