Skip to content

chore(e2e): upgrade Playwright to 1.61.1 for Ubuntu 26.04 runners - #1171

Merged
jgalat merged 1 commit into
masterfrom
chore/playwright-1.61
Nov 19, 2026
Merged

jgalat merged 1 commit into
masterfrom
chore/playwright-1.61

Conversation

@jgalat

@jgalat jgalat commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Upgrades @playwright/test from 1.59.1 to 1.61.1 so the E2E workflow runs again.

GitHub's ubuntu-latest runner moved to Ubuntu 26.04, and Playwright 1.59.1 refuses to install Chromium there ("Playwright does not support chromium on ubuntu26.04-x64"). The smoke job on every PR and the nightly run on master have been failing at the "Install Chromium" step since 2026-11-19, before any test runs. 1.61 is the first Playwright line that supports 26.04.

Why 1.61.1 and not latest

The latest release, 1.65.1, breaks specs that freeze and step the browser clock. On master, 50 runs of flows/failures-governance, flows/governance-queue-execute, flows/governance-support-variants, index-dtf/auctions/launch-write and flows/settings give:

Playwright Result
1.59.1 50 passed
1.61.1 50 passed
1.65.1 38 passed, 12 failed

So the version is pinned exact rather than with a caret. Going past 1.61 needs the first breaking version found and e2e/helpers/clock.ts adapted; that is recorded in docs/plans/FOLLOWUPS.md.

Verification

  • pnpm typecheck, pnpm exec vitest run e2e/helpers/tests, pnpm e2e:check.
  • Full offline e2e on 1.61.1 (Chromium 149): 284 passed, 9 failed, 4 skipped. The nine also fail or flake on master with 1.59.1: collateral-app-links (4), proposer-cancel revert (2), dtf-nav-state-cleanup (2), reload-chain-identity.
  • The lockfile change is limited to the Playwright packages.

Not verified locally: the install on an Ubuntu 26.04 runner. This PR's own smoke run is that check.

Notes

Summary by CodeRabbit

  • Chores
    • Pinned the Playwright test tool to version 1.61.1.
  • Documentation
    • Recorded follow-up notes on browser installation constraints and test failures observed with newer versions, along with upgrade considerations.

ubuntu-latest moved to Ubuntu 26.04, and Playwright 1.59.1 refuses to
install Chromium there, so the E2E workflow fails before any test runs.
1.61 is the first line that supports 26.04.

Pinned exact: 1.65.1 breaks the frozen-clock write specs (12 failures in
50 runs of the governance and settings failure specs; none on 1.59.1 or
1.61.1). The follow-up is recorded in docs/plans/FOLLOWUPS.md.
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request pins @playwright/test to version 1.61.1 and adds a dated follow-up documenting reported Playwright version constraints and work needed before a future upgrade.

Changes: Playwright version pin

Layer / File(s) Summary
Pin and document Playwright upgrade constraints
package.json, docs/plans/FOLLOWUPS.md
@playwright/test changes from the ^1.59.1 range to exact version 1.61.1. The follow-up records reported Chromium installation and frozen-clock test results, and notes investigation and clock-helper adaptation needed before upgrading past 1.61.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

Suggested reviewers: lcamargof, juampirombola

Merge Risk: Minimal · up to 9c7a8

This updates the E2E test tooling to a Playwright version that supports Ubuntu 26.04 and documents future upgrade work. It does not change production behavior, and no merge-blocking risk was found. Developers need to run the Chromium install once after pulling.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: upgrading @playwright/test to 1.61.1 to support Ubuntu 26.04 runners. The raw summary confirms the package.json pin change and the FOLLOWUPS doc. The title uses the co…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: upgrading @playwright/test to 1.61.1 to support Ubuntu 26.04 runners. The raw summary confirms the package.json pin change and the FOLLOWUPS doc. The title uses the conventional commit prefix 'chore(e2e):', which is specific and descriptive, and it is a single sentence of 65 characters.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e2bb0cef-355c-4e7c-a583-6004dbe1a72a
Commits

Reviewing files that changed from the base of the PR and between c2db9cd and 9c7a813.

Files ignored due to path filters: 1

  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 2

  • docs/plans/FOLLOWUPS.md
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@jgalat
jgalat merged commit 095640f into master Nov 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants