Repository navigation
chore(e2e): upgrade Playwright to 1.61.1 for Ubuntu 26.04 runners - #1171
Conversation
ubuntu-latest moved to Ubuntu 26.04, and Playwright 1.59.1 refuses to install Chromium there, so the E2E workflow fails before any test runs. 1.61 is the first line that supports 26.04. Pinned exact: 1.65.1 breaks the frozen-clock write specs (12 failures in 50 runs of the governance and settings failure specs; none on 1.59.1 or 1.61.1). The follow-up is recorded in docs/plans/FOLLOWUPS.md.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Summary
Upgrades
@playwright/testfrom 1.59.1 to 1.61.1 so the E2E workflow runs again.GitHub's
ubuntu-latestrunner moved to Ubuntu 26.04, and Playwright 1.59.1 refuses to install Chromium there ("Playwright does not support chromium on ubuntu26.04-x64"). The smoke job on every PR and the nightly run on master have been failing at the "Install Chromium" step since 2026-11-19, before any test runs. 1.61 is the first Playwright line that supports 26.04.Why 1.61.1 and not latest
The latest release, 1.65.1, breaks specs that freeze and step the browser clock. On master, 50 runs of
flows/failures-governance,flows/governance-queue-execute,flows/governance-support-variants,index-dtf/auctions/launch-writeandflows/settingsgive:So the version is pinned exact rather than with a caret. Going past 1.61 needs the first breaking version found and
e2e/helpers/clock.tsadapted; that is recorded indocs/plans/FOLLOWUPS.md.Verification
pnpm typecheck,pnpm exec vitest run e2e/helpers/tests,pnpm e2e:check.collateral-app-links(4),proposer-cancelrevert (2),dtf-nav-state-cleanup(2),reload-chain-identity.Not verified locally: the install on an Ubuntu 26.04 runner. This PR's own smoke run is that check.
Notes
pnpm exec playwright install chromiumonce after pulling this.ubuntu-24.04as a stopgap. Once this merges, that pin can be dropped.Summary by CodeRabbit