Skip to content

Use the shared verify-lockfile workflow - #255

Merged
tillrohrmann merged 1 commit into
mainfrom
shared-verify-lockfile
Nov 2, 2026
Merged

tillrohrmann merged 1 commit into
mainfrom
shared-verify-lockfile

Conversation

@tillrohrmann

Copy link
Copy Markdown
Contributor

Summary

Replaces the copied job in verify-lockfile.yml with a call to the shared workflow in restatedev/restate (restatedev/restate#5721):

jobs:
  verify:
    uses: restatedev/restate/.github/workflows/verify-lockfile.yml@main

The gh-actions-lock version is then maintained in one place for all restatedev repositories. Dependabot can't bump it because it is a CLI argument (gh extension install github/gh-actions-lock --pin v0.4.0), not a uses: reference. The workflow name and triggers stay as they are.

  • actions.lock is relocked: the verify-lockfile.yml entry no longer lists actions/checkout, which is now covered by restatedev/restate's own lockfile.
  • The check is now reported as verify / verify instead of verify. No branch protection or ruleset in this repository requires the old name.

Test plan

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Test Results

  8 files  ±0    8 suites  ±0   3m 26s ⏱️ -16s
 71 tests ±0   71 ✅ ±0  0 💤 ±0  0 ❌ ±0 
322 runs  ±0  322 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 79e4c50. ± Comparison against base commit 0e9c675.

♻️ This comment has been updated with latest results.

@tillrohrmann

Copy link
Copy Markdown
Contributor Author

@pullfrog please rebase and review

Call the reusable workflow instead of keeping a copy of the job, so the
gh-actions-lock version is maintained in one place.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog
pullfrog Bot force-pushed the shared-verify-lockfile branch from 4f0b43d to 79e4c50 Compare November 2, 2026 16:58

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Rebased onto main (0e9c675, which added pullfrog.yml). The actions.lock conflict is resolved: actions/checkout@v6.1.0 stays because pullfrog.yml uses it, and actions/checkout@v7.0.1 is dropped because no workflow references it any more. gh actions-lock --verify (v0.4.0) passes locally: "All 7 workflows valid".

I checked the shared restatedev/restate/.github/workflows/verify-lockfile.yml@main. It declares workflow_call, needs no inputs or secrets, asks only for contents: read (the caller grants the same), and checks out the caller's repo with persist-credentials: false. The caller keeps its own name and triggers, so behaviour matches the job it replaces.

One thing to be aware of, not a blocker: @main is a mutable ref, and the lockfile records verify-lockfile.yml as [], so the reusable workflow itself isn't pinned here. Any change merged to restatedev/restate main runs here on the next PR. That's the point of centralising it, and the token is read-only, so the risk is low.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@tillrohrmann
tillrohrmann merged commit 5e6cfed into main Nov 2, 2026
11 checks passed
@tillrohrmann
tillrohrmann deleted the shared-verify-lockfile branch November 2, 2026 17:12
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant