Skip to content

Upgrade restate-sdk-shared-core to 8.4.0 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igalshilman merged 1 commit into from
Nov 9, 2026
Merged

Upgrade restate-sdk-shared-core to 8.4.0 #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ tracing = "0.1"
tracing-subscriber = { version = "0.3", features = ["fmt", "env-filter"] }
# The feature `sql` is the sessions' storage: the SQLite-compatible database kept in an
# object's state, with its page cache (foyer); `tunnel` is Restate Cloud's.
restate-sdk-shared-core = { version = "8.3.1", features = [
restate-sdk-shared-core = { version = "8.4.0", features = [

@pullfrog pullfrog Bot Nov 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.4.0 changes the format of the sessions' state, and the change only works in one direction. Every flush now writes an SH23 head with tail keys named by nonce (v22/tail/<version>-<nonce>/<part>). 8.4.0 still reads the old SH22 heads, but 8.3.1's Head::decode accepts only SH22 and fails with invalid("head"). v1.4.2 already ships sql sessions on 8.3.1. So once a release with this bump flushes a session key, rolling back to ≤1.4.2, or an old deployment still serving that key, can no longer open it. The PR description says nothing about this, and the release notes should say it.

@igalshilman igalshilman Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct: this was decided in sdk-shared-core#113 ("Older SDKs can't read SH23 heads; no compatibility release at this point"), so this PR can't add a path back. I've added it to the PR description, so it can go into the release notes.

Generated by Claude Code

"request_identity",
"sha2_random_seed",
"rust_crypto",
Expand Down
Loading