Skip to content

Use the shared verify-lockfile workflow - #140

Merged
tillrohrmann merged 1 commit into
mainfrom
shared-verify-lockfile
Nov 2, 2026
Merged

tillrohrmann merged 1 commit into
mainfrom
shared-verify-lockfile

Conversation

@tillrohrmann

Copy link
Copy Markdown
Contributor

Summary

Replaces the copied job in verify-lockfile.yml with a call to the shared workflow in restatedev/restate (restatedev/restate#5721):

jobs:
  verify:
    uses: restatedev/restate/.github/workflows/verify-lockfile.yml@main

The gh-actions-lock version is then maintained in one place for all restatedev repositories. Dependabot can't bump it because it is a CLI argument (gh extension install github/gh-actions-lock --pin v0.4.0), not a uses: reference. The workflow name and triggers stay as they are.

  • actions.lock is relocked: the verify-lockfile.yml entry no longer lists actions/checkout, which is now covered by restatedev/restate's own lockfile.
  • The check is now reported as verify / verify instead of verify. No branch protection or ruleset in this repository requires the old name.
  • taiki-e/install-action@nextest → @v2.89.0 with tool: nextest. The nextest ref is re-pointed to new commits on every release, so the locked commit is no longer in the action repo's history and the lockfile check fails (unreachable pin) from the next run on main onward. The version tag doesn't move; it still installs the latest nextest.

Test plan

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Test Results

  8 files  ±0    8 suites  ±0   3m 37s ⏱️ +11s
 52 tests ±0   52 ✅ ±0  0 💤 ±0  0 ❌ ±0 
227 runs  ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f8afac5. ± Comparison against base commit 61d3bb8.

♻️ This comment has been updated with latest results.

@tillrohrmann

Copy link
Copy Markdown
Contributor Author

@pullfrog please rebase and review

Call the reusable workflow instead of keeping a copy of the job, so the
gh-actions-lock version is maintained in one place.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog
pullfrog Bot force-pushed the shared-verify-lockfile branch from 73ebd74 to f8afac5 Compare November 2, 2026 16:57

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Rebased onto main (61d3bb8). Since then the PR only replaces the copied job with the reusable workflow and relocks.

  • Rebase scope change: main already moved ci.yml and the new pullfrog.yml off the moving taiki-e/install-action@nextest tag to @v2.87.32 with tool: nextest. I resolved the conflict in favor of main's version, so there is still only one locked install-action version. The PR no longer includes the @v2.89.0 bump, and I removed that paragraph from the commit message. The third bullet of the PR description is now stale.
  • Lockfile: I checked locally with gh actions-lock --verify (v0.4.0) and all 6 workflows are valid. actions/checkout@v7.0.1 has been dropped, since only the old inline job used it. @v6.1.0 stays because pullfrog.yml uses it.
  • Permissions: the caller grants contents: read, which is exactly what the shared job needs. actions/checkout in the called workflow checks out the caller repository, so it still verifies this repo's actions.lock.
  • FYI, not blocking: @main is a moving ref, and actions.lock records verify-lockfile.yml: []. Changes to the shared workflow in restatedev/restate therefore take effect here right away, without a relock. This is the intended trade-off for keeping the extension version in one place.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@tillrohrmann
tillrohrmann merged commit 6e52842 into main Nov 2, 2026
6 checks passed
@tillrohrmann
tillrohrmann deleted the shared-verify-lockfile branch November 2, 2026 17:12
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant