test: add verify route tests and document the moderator, emeritus, and onboarding roles - #1637
Merged
RUKAYAT-CODER merged 4 commits intoSep 28, 2026
Conversation
|
@a-malik-gh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request closes #1408, #1480, #1481, and #1482.
Adds the missing email-verification verify route tests, and the three
governance documents the project was missing, each with a regression test
alongside it.
src/app/api/auth/email-verification/verify/__tests__/route.test.ts— theGET and POST verify handlers, including the missing-token, expired-token, and
failure paths.
Governance/roles/MODERATOR.mdandGovernance/roles/MODERATOR.test.ts—moderator duties, moderation powers and limits, and the appointment and
removal process.
Governance/roles/EMERITUS.mdandGovernance/roles/EMERITUS.test.ts—emeritus status, the privileges retained and removed, and how the status is
granted.
Governance/processes/ONBOARDING.mdandGovernance/processes/ONBOARDING.test.ts— the onboarding steps, theresources a new contributor receives, and who owns onboarding.
The governance documents follow the conventions of the existing files in
Governance/: the same heading structure, a maximum line width of 82 columns,and a
## Regression Testssection naming the companion test file. Each testpins the document structure, the required content, the cross-references to
policies that already exist, and the line-width and placeholder rules, so the
documents cannot silently drift. Changes to the governance issues are limited
to the
Governance/folder.Closes #1408
Closes #1480
Closes #1481
Closes #1482