Repository navigation
console: polish the home, visualize and not found pages - #2
Merged
Merged
Conversation
The page for an unknown address only said "Not found!". It now says the address may be mistyped or the page may have moved, and links to the home page and to the documentation. The page also sets its own title: the tab said "FlowScope" alone.
On a large screen, the bar above the pages only held the theme switch and the avatar. Both move to the foot of the menu, with the name of the user, and the bar is gone. On a small screen the menu is closed, so the bar stays: it opens the menu and shows the logo. Also in the menu: - the current page gets the tint of the brand, in place of a solid black or white block, - the button to collapse the menu says "Collapse menu", not "Close", - the links are in a nav landmark. The page had two nested main landmarks, one from the sidebar block and one from the layout. The sidebar block is now a plain block.
The home page had two numbers on half of its width, five small pies
whose shares were not written, and a list of about 60 fields for the
last flow, many of them empty, with a blank area next to it.
- Four numbers in one row: the flow rate, the exporters, the traffic
now and its peak. The last two come from the data of the graph, with
the period computed from it.
- The top lists are ranked bars with the share of each entry. The
protocols and the IP versions, which have a few classes, get one
split bar.
- The fields of the last flow are in sections (flow, exporter, source,
destination, interfaces). The fields without a value are listed by
name behind a button. A zero is a value and stays.
- The axis of the graph shows the unit ("150 Gbps", not "150.00G").
- The titles of the panels are headings.
The header of a page can also drop its description on a small screen.
The visualize page will use it.
On a phone, the options filled the first screen and the graph was below it. The graph now comes first. A bar at the bottom opens the options in a sheet and runs the query. On a large screen, the options stay next to the graph. In the options: - the button to apply is out of the scrolling part, so it stays in view, - the unit is a list with full names, in place of six buttons like "L3b/s" and "->%" written with small letters, - the buttons with only an icon are 32 pixels wide, up from 16, - the fields which are not inputs are named for screen readers, and the section titles are headings. In the graphs: - ten series get ten colors which differ in hue and in lightness. The four hues of the brand were repeated in shades, and the fifth series was hard to tell from the first, - the axis shows the unit, - the summary and the title of the tab use a 24-hour clock, like the axis. The smallest text size goes from 11 to 12 pixels.
The grid graph asks for the color of the "Other" row, which it does not draw, with the index -1. The palette with ten colors returned nothing for it and the graph failed to render. The previous palette shifted odd indexes, which hid the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish of three screens of the console, from a review of the running demo: the home page, the visualize page and the not found page. One commit for each, plus one for the menu they share.
Not found page
Menu and page shell
mainlandmark in place of two nested ones, and anavlandmark for the menu.Home page
Visualize page
Checks
pnpm lint,pnpm test(88 tests, 15 of them new) andpnpm buildpass.Not checked