Repository navigation
console: show the not found page for an unknown document - #6
Merged
Merged
Conversation
An address like /docs/unknown is served by the documentation page, not by the not found page. It showed an empty table of contents and a red box, "Unable to fetch documentation page! Document not found.", with no way out. When the server answers 404 for a document, the documentation page now shows the same view as the not found page: what happened, and links to the home page and to the documentation. The title of the tab says "Not found". Other errors keep the red box. The view moves to its own component, shared by both pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An address like
/docs/unknownis served by the documentation page, not by the not found page. It showed an empty table of contents and a red box with no way out.Checks
pnpm lint,pnpm testandpnpm buildpass. The built404.htmlstill has its title and its text./docs/0, followed "Open the documentation" (the introduction opens), went back (the view returns), followed "Back to home".Not checked