Skip to content

fix(object-store): honor concurrency limits for MinIO - #26679

Open
Li0k wants to merge 2 commits into
risingwavelabs:mainfrom
Li0k:li0k/fix-minio-object-store-concurrency-limit
Open

fix(object-store): honor concurrency limits for MinIO#26679
Li0k wants to merge 2 commits into
risingwavelabs:mainfrom
Li0k:li0k/fix-minio-object-store-concurrency-limit

Conversation

@Li0k

@Li0k Li0k commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Route the OpenDAL MinIO backend through the shared operator-construction path already used by S3. This makes req_concurrency_limit and http_concurrent_limit apply to MinIO as configured.

The shared path finishes the caller's already-layered operator directly when both limits are disabled, so every backend retains exactly one logging layer.

Add a regression test covering the default, request-limit, and HTTP-limit operator composition.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@Li0k Li0k added ci/run-opendal-tests type/fix Type: Bug fix. Only for pull requests. labels Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/run-opendal-tests type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant