Repository navigation
Conversation
I noticed today that Java had been done something a little weird in that
instead of hooks/middleware like in Go, we ended up with a broad
`Extension` interface that does everything.
Here, give Java a more normal implementation compared to other
languages. We have specific hooks/middleware like:
public interface HookInsertBegin extends Hook {
/**
* Runs in the insertion's transaction. Throwing fails and rolls back the insertion, including
* application writes made using this connection. Options are the caller's overrides, before
* merging with job-type defaults.
*/
void insertBegin(Connection connection, JobType<?> type, Object args, InsertOptions options)
throws Exception;
}
Which extends from a base like `Hook`:
public interface Hook extends Plugin {}
Which extends from `Plugin` so that everything can be set together:
public interface Plugin {}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed today that Java had been done something a little weird in that
instead of hooks/middleware like in Go, we ended up with a broad
Extensioninterface that does everything.Here, give Java a more normal implementation compared to other
languages. We have specific hooks/middleware like:
Which extends from a base like
Hook:Which extends from
Pluginso that everything can be set together: