Repository navigation
Ruby: Make work_begin/work_end behave more like Go hooks - #1520
Merged
Merged
Conversation
bgentry
approved these changes
Oct 19, 2026
A few tweaks to Ruby's `work_begin`/`work_end`: * `work_begin` failures skip the worker and end hooks. * Returning an error from `work_end` preserves or replaces the failure. `nil` clears it. * Each hook receives the previous hook's result.
brandur
force-pushed
the
brandur-ruby-work-end-fix
branch
from
October 19, 2026 07:11
ce30e53 to
c5c842f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few tweaks to Ruby's
work_begin/work_end:work_beginfailures skip the worker and end hooks.Returning an error from
work_endpreserves or replaces the failure.nilclears it.Each hook receives the previous hook's result.