[DevChiniwala]

• Release the cached global Envoy handle after shutdown cleanup.
• Add regression coverage that verifies the callback context is released.

Fixes #5766

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[the-company-company]

✅ No issues found

_{Reviewed commit 49f2fb2.}

[DevChiniwala]

The Co review passed with no findings. GitHub has not run the latest-head Rust CI because it requires maintainer approval: Rust CI. Could a maintainer approve that run so the Envoy lifecycle regression can be checked in CI? The cached handle is cleared only if it still belongs to the stopping instance, before the stopped notification is published.

[DevChiniwala]

Updated this branch in 52ca24ac, merging current main (9e01a0ac) and resolving the conflict.

• Release the matching global handle after ordinary shutdown, before publishing the stopped signal.
• Preserve upstream's intentional caching of terminal registration errors. A new regression drives the real registration-rejection path and checks that the same handle and error remain cached.
• The ordinary-shutdown regression still fails on unchanged current upstream, confirming that the callback-retention defect remains relevant.

Validation on the pushed source tree:

• cargo +1.98.0 test -p rivet-envoy-client --locked: 2 passed; no network connection required.
• Scoped Rust formatting, locked workspace metadata, and cargo +1.98.0 rustc -p rivet-envoy-client --locked -- -D warnings: passed.
• Optional Clippy checks remain failing under the workspace's simulation-migration lint policy; comparisons against unchanged upstream with the same regression fixtures reproduce the failures. No lint suppressions or unrelated migrations were added.

Upstream CI results are still pending; previous runs required maintainer approval. The wasm target and JS protocol generation were not exercised by these native checks. The updated code and regression coverage are pushed and available for review.

[RivetAgent]

Changes look good; no high-confidence bugs or compliance issues found.

The global-handle cleanup preserves terminal registration errors and checks instance identity before clearing the cache. The new lifecycle tests cover both ordinary shutdown and rejection retention.

No issues found. Checked for bugs and CLAUDE.md compliance; no CLAUDE.md files were present.

Limitations: Tests were not run. GitHub authentication was unavailable, so PR status and prior Claude comments could not be verified.

Copy prompt to fix all

Fix all actionable findings in the latest Ironworks code review on PR rivet-dev/rivet#5848. Inspect every referenced location, address each finding without changing unrelated behavior, run the relevant tests, and summarize what changed.