Repository navigation
fix(pegboard-envoy): send an actor's own WebSocket close back to it - #5950
Open
eersnington wants to merge 1 commit into
Open
eersnington wants to merge 1 commit into
eersnington wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an actor called
ws.close(), pegboard-envoy forwarded the close to the client and ended the tunnel. It never sent the close back to the actor, so the actor'sclosehandler never ran, the socket stayed open, and the actor never went to sleep. Client-initiated closes were not affected.ToEnvoyWebSocketCloseback to the actor, with the same code and reason, after it forwards the actor's close to the client.hibernate: trueis not sent back.ws.close(4000)closeeventChecked with a RivetKit 3.0.0-preview.4 actor on a local Engine, 3 runs each. Client-initiated closes behave as before.