Repository navigation
fix(rivetkit): retry connection open after depot.unavailable - #5959
Open
kunalgoesbyken wants to merge 3 commits into
Open
kunalgoesbyken wants to merge 3 commits into
kunalgoesbyken wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5953.
depot.unavailableis now classified likedepot.request_deadline_exceeded: a reconnect signal, not a request retry. A connection that hits it while the engine's storage is starting retries the open instead of goingidlefor good.#rejectPendingPromises, theget_params_failedpath,dispose) also clears the queue first, so an action a caller saw fail never runs later.Type of change
How Has This Been Tested?
vitest run tests/lifecycle-errors.test.tsinrivetkit-typescript/packages/rivetkit:openWebSocketthrowsdepot.unavailable. Before the change the connection goesidle; after it, the connection opens again.Init, then is sent exactly once.biome checkon the changed files.