Repository navigation
Drop host-state cleanups for hosts set up before UCloud (P13) - #45
Merged
Merged
Conversation
Removed: - Relay networking: retiring per-sandbox ucloud_relay_<slot> nft tables (legacy_relay_policy_table, in the rebuild and in removal) and per-interface FORWARD -i <if> -j ACCEPT rules (_remove_legacy_relay_accepts and the check in relay policy removal). - vm_init: retiring the ucloud-sandbox-heartbeat timer and service. - Hibernation store: the shared lock on the root-wide .store.lock that only excluded a pre-2026-09-08 process. - gVisor: the non-pinned-commit branches of distribution_files and installed_sidecar_fingerprints (both now refuse any commit but GVISOR_COMMIT and require the manifest and companions), the `if companions` guards in boot_config_sha256 and deploy staging. - Resident memory sampling (agent and noded): the container-id fallback for bundles without linux.cgroupsPath; such a bundle is not sampled. - .ucloud-overlay.json schema 1: Docker-store bundles are now written as schema 2 too, and only schema 2 is read. Why it is safe: every production worker was first set up on UCloud. The 2026-10-24 evidence read on all six workers shows no ucloud_relay_<n> tables, no per-interface FORWARD ACCEPT rules, no heartbeat units, no old overlay schema, and UCLOUD_DIRECT_RUNSC_COMMIT equal to GVISOR_COMMIT. Production workers use host-EROFS environments, whose bundles were already schema 2 and always name their cgroup. Config: no keys change. The boot fingerprint of a pinned install is unchanged (its companions were already bound). 0.10.0 reads schema-2 bundles, so a rollback needs nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rlrs
force-pushed
the
cleanup/no-pre-ucloud-host-cleanups
branch
from
October 24, 2026 12:05
4343b44 to
e7636f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan item P13: one-off cleanups for hosts first set up before the move to UCloud.
What goes
relay_network.py,direct_network.py): retiring per-sandboxucloud_relay_<slot>nft tables (in the table rebuild and in per-sandbox removal) and per-interfaceFORWARD -i <if> -j ACCEPTrules (_remove_legacy_relay_accepts, and the check in relay policy removal).ucloud-sandbox-heartbeattimer and service. Nothing else in vm_init changes..store.lock, which only excluded a process from before 2026-09-08. The per-incarnation locks stay.distribution_filesandinstalled_sidecar_fingerprints. Both now refuse any commit other thanGVISOR_COMMIT, and require the build manifest and the companion binaries. Theif companionsguards inboot_config_sha256and in deploy staging go with them.linux.cgroupsPath. The sampler now takes the expected cgroup path as a required argument, and a bundle without one is not sampled. The Python/Rust parity cases are updated to match..ucloud-overlay.jsonschema 1: Docker-store bundles were still written as schema 1. They are now written as schema 2, like host-EROFS bundles, and only schema 2 is read.test_deploynow builds the complete pinned distribution in its plan fixture.Evidence
From the read-only evidence pass on 2026-10-24, on all six live workers: no
ucloud_relay_<n>tables, no per-interface FORWARD ACCEPT rules, no heartbeat units, no old overlay schema, andUCLOUD_DIRECT_RUNSC_COMMITequal to the pinnedGVISOR_COMMIT(W4). Production workers use host-EROFS environments (immutable-environment-host-erofs-v1). Their bundles were already schema 2 and always name their cgroup.Compatibility and rollback
## Unreleasedsays so.Checks
uv run ruff check sandboxes tests scripts: clean.scripts/check_test_rules.py --update: the baseline went down by 3.cargo test --lockedfor noded passes, includingresident_python_parity.test_relay_network_linux(linux tier) was edited but not run here.🤖 Generated with Claude Code