Repository navigation
release: repack can replace ucloud-noded - #49
Merged
Merged
Conversation
add_noded() lost its only caller when one-off release tooling was pruned (f706be5), so no release tool could put a rebuilt noded into a sandbox bundle; a release whose noded changed had to be assembled by hand. repack_node_bundle.py gains --noded-build-dir, which installs runtime/noded/build_pinned.sh's output through add_noded (which checks the build manifest, target and digest, and refuses builder bundles). add_noded gets the same test its chunk_serve and nydusd siblings have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release tooling:
repack_node_bundle.py --noded-build-dirinstallsruntime/noded/build_pinned.sh's output into a sandbox bundle through the existingadd_noded(), which lost its caller in f706be5. Needed for 0.10.1, whose noded changed (P1, P9, P11, P13, P14, #31, #48). Adds a test foradd_nodedmatching its siblings and one line in docs/operations.md. Checked: ruff, check_test_rules, test_repack_node_bundle.🤖 Generated with Claude Code