Repository navigation
Conversation
Adds .agents/setup for Amp orbs (Debian 12, no GPU). Installs only the toolchain pinned by CI and manifests and ends with a dependency fetch.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
🧰 Additional context used🔍 Remote MCP LinearLinear
Retrieval limitationsSome requested queries to Linear were not sent; their results are unavailable. 🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughAdds a repeatable Debian 12 setup script. It installs missing build and lint packages, configures the kernels project for CPU-only builds, and prints a completion message. The script does not run tests. ChangesDebian setup
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The setup flow is ready to merge; normal host prerequisites such as sudo access and apt repository availability remain environmental requirements. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the tools in place Comment |
There was a problem hiding this comment.
This PR adds a well-structured Amp orb setup script with proper bash safety practices (set -euo pipefail), idempotent package installation, and appropriate error handling. The script correctly handles sudo detection and package management for the CPU-only build path. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Up to standards ✅🟢 Issues
|
What
Adds
.agents/setup, the script Amp runs on a fresh orb before it saves the snapshot (docs). It's an executable bash script withset -euo pipefailthat runs from the repo root. It's idempotent: on a re-run, anything already installed is skipped. It installs only what this repo's CI and manifests need, and ends with a dependency fetch or prebuild, not a test run, so it stays well under the 20-minute setup limit.What it installs
Pins and notes
cmake_minimum_required(3.24)(Debian 12 has 3.25.1); CPU path-DBKL_ENABLE_CUDA=OFFand thepython3 tools/check_*.py/test_*.pychecks from ci-cpu.yml use only the orb's system python3.-DBKL_ENABLE_CUDA=ON(kernel builds, benches, compute-sanitizer) needs the self-hosted[self-hosted, Linux, X64, CUDA]runner. On an orb, only the CPU checks and docs/tools work.No GPU on orbs
Amp orbs are Debian 12 cloud VMs with no GPU. The GPU-gated parts of this repo can't run on an orb; the notes above give the CPU path.
Testing
bash -nandshellcheck0.10.0: clean.Things to double-check
~/.cargo/bin,~/.juliaup/binand~/.local/binand add those to the login profile. The script exports them for its own run. In a non-login, non-interactive shell they weren't on PATH, so check that Amp's agent shell findscargo/julia/uv.apt-getusesAcquire::Retries=5, but a deb.debian.org 500 can still fail the setup. Amp doesn't save a snapshot from a failed setup, so a retry fixes it.amp projects snapshots delete <project>to force a fresh setup, or wait for it to expire (Amp reuses a snapshot for up to 72 hours).Propose-only: please review before merging.
Summary by cubic
Adds
.agents/setup, the bash script Amp runs on a fresh orb before saving a snapshot (Debian 12, CPU only). It installs only the packages this repo's CI needs —build-essential,cmake,shellcheck— and ends with the CPU-only CMake configure (-DBKL_ENABLE_CUDA=OFF), which skips every kernel target so no nvcc is required.Written for commit 50128b1. Summary will update on new commits.