Repository navigation
refactor: enforce #[\Override] and drop unused psalm suppressions - #50
Merged
Merged
Conversation
The remaining suppressions cover runtime guards against callers that ignore docblock types, and untyped class constants, which need PHP 8.3. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
#[\Override]on methods that implement or override a parent one (ensureOverrideAttribute);srcalready carried it, the test stub service gets it too. PHP 8.2 ignores the attribute, so no polyfill is needed.@psalm-suppressannotations and theMixedReturnStatement,UnusedPsalmSuppress,InvalidAttributeandUndefinedAttributeClasshandlers that no longer matched any issue.psalm.xml:RedundantConditionGivenDocblockTypeandDocblockTypeContradictionfor the runtime guards inContextoffsets and the service interfaceNAME, andMissingClassConstType, because typed class constants need PHP 8.3.Checklist
--php-version8.2, 8.3 and 8.4 (without ext-protobuf, as in CI)3.x