Skip to content

fix: HNVSK carries the signature's security profile version (PIN:2 for two-step) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robocode13 merged 1 commit into from
Sep 13, 2026
Merged

fix: HNVSK carries the signature's security profile version (PIN:2 for two-step) #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,13 @@ export class CustomerMessage extends Message {

const now = new Date();

// The encryption header carries the same security profile as the
// signature: PIN version 2 for a two-step TAN method, 1 for one-step.
// Some banks (Consorsbank, BLZ 76030080) reject a two-step dialog whose
// HNVSK still says PIN:1 with "9010 Ungültiger Signaturaufbau".
const hnvsk: HNVSKSegment = {
header: { segId: HNVSK.Id, segNr: 998, version: HNVSK.Version },
secProfile: { secMethod: 'PIN', secVersion: 1 },
secProfile: { secMethod: 'PIN', secVersion: firstSignature.secProfile.secVersion },
secFunc: 998,
secRole: 1,
secId: { partyType: 1, partyId: firstSignature.secId.partyId },
Expand Down
23 changes: 23 additions & 0 deletions src/tests/message.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,27 @@ describe('CustomerMessage', () => {

const _message = Message.decode(encodedMessage);
});
it('encrypts with the security profile version of the signature (two-step: PIN:2)', () => {
const customerMessage = new CustomerMessage('0', 1);

customerMessage.addSegment(hkidn);
customerMessage.addSegment(hkvvb);
customerMessage.sign(280, '12030000', '12345678', '123', '0', 900, '12345');
const encodedMessage = customerMessage.encode();

expect(encodedMessage).toContain("'HNVSK:998:3+PIN:2+998+");
expect(encodedMessage).toContain('HNSHK:2:4+PIN:2+900+');
});

it('encrypts with the security profile version of the signature (one-step: PIN:1)', () => {
const customerMessage = new CustomerMessage('0', 1);

customerMessage.addSegment(hkidn);
customerMessage.addSegment(hkvvb);
customerMessage.sign(280, '12030000', '12345678', '123', '0');
const encodedMessage = customerMessage.encode();

expect(encodedMessage).toContain("'HNVSK:998:3+PIN:1+998+");
expect(encodedMessage).toContain('HNSHK:2:4+PIN:1+999+');
});
});