Api improvements - #1185
Merged
Merged
Conversation
0xfornax
force-pushed
the
api-improvements
branch
2 times, most recently
from
August 20, 2026 19:15
31ccf2e to
9fce37d
Compare
0xfornax
marked this pull request as ready for review
August 21, 2026 19:30
jshufro
reviewed
Aug 24, 2026
0xfornax
force-pushed
the
api-improvements
branch
from
August 25, 2026 14:43
e4bdd5c to
05fda13
Compare
0xfornax
force-pushed
the
api-improvements
branch
from
August 25, 2026 14:51
05fda13 to
aaaf93f
Compare
jshufro
reviewed
Aug 25, 2026
jshufro
approved these changes
Aug 25, 2026
jshufro
left a comment
jshufro
left a comment
Contributor
There was a problem hiding this comment.
A few suggestions but this feels like a good step forward overall so nothing urgent or blocking
0xfornax
force-pushed
the
api-improvements
branch
from
August 25, 2026 20:34
058e0ed to
635b9f3
Compare
Merging this branch changes the coverage (1 decrease, 22 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds configurable Smart Node HTTP API exposure (closed, localhost, or external) and a dedicated API settings category with a new API token. Remote and local clients must authenticate according to a token-requirement mode (all routes, or only mutating ones such as transactions, wallet operations, and validator exits).
Adds rate limit capabilities. The default will not enforce limits.
Request logs now include the client IP.