Repository navigation
Format ... (spread/rest) token - #168
Merged
Merged
Conversation
Brighterscript now lexes `...` as a single DotDotDot token, in
preparation for spread and destructuring syntax. Update the formatter
to handle it.
- Remove whitespace between `...` and its operand (`... a` -> `...a`)
for spread, rest parameters, and destructuring. Whitespace before a
trailing comment is kept.
- Fix curly brace spacing overwriting the token next to `{` or `}`
when no whitespace token was present. Under the old lexer this
turned `{...a}` into `{ ..a }`.
- Add tests for spread/rest/destructuring formatting and multi-line
indentation.
iObject
marked this pull request as ready for review
October 9, 2026 19:03
iObject
commented
Oct 9, 2026
TwitchBronBron
changed the title
... (spread/rest) token... (spread/rest) token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brighterscript now lexes
...as a single DotDotDot token, in preparation for spread and destructuring syntax. Update the formatter to handle it....and its operand (... a->...a) for spread, rest parameters, and destructuring. Whitespace before a trailing comment is kept.{or}when no whitespace token was present. Under the old lexer this turned{...a}into{ ..a }.