Repository navigation
Only build the shadowed-variable range when reporting it - #1867
Merged
Merged
Conversation
detectShadowedLocalVar() is called for every assignment, for each item and parameter during scope validation, but the name range is only used when a diagnostic is added. Pass the name token and resolve the range on demand. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…dow-name-range # Conflicts: # src/bscPlugin/validation/ScopeValidator.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1845. Scope validation calls
detectShadowedLocalVar()for every assignment, for each item and function parameter, and each call built aLocationfor the name up front. The range is only needed when a diagnostic is actually added, so this passes the name token instead and resolves the range on demand.ScopeValidator.detectShadowedLocalVar()now takesnameToken: Locatableinstead ofnameRange: Range(public method, so a small API change)Verified with
npm run test:nocover.🤖 Generated with Claude Code