Repository navigation
Don't shrink the import path range again when cloning - #1868
Merged
Merged
Conversation
The ImportStatement constructor narrows the path token's range to exclude the quotes. A clone copies the already-narrowed token, so the constructor narrowed it a second time. Only narrow a token whose range still includes the quotes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…lone-range # Conflicts: # src/parser/AstNode.spec.ts # src/parser/Statement.ts
TwitchBronBron
marked this pull request as ready for review
October 16, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1845. The
ImportStatementconstructor narrows the path token's range to exclude the quotes, but a clone copies the already-narrowed token, so every clone lost another character on each side. The constructor now only narrows a token whose range still includes the quotes. This bug predates the location change.Verified with
npm run test:nocover(new test clones twice and checks the range).🤖 Generated with Claude Code