Repository navigation
Compare callables, not ranges, when relating duplicate functions - #1869
Merged
Merged
Conversation
The duplicate-function diagnostic skipped "itself" by comparing nameRange objects by reference. That only works because BrsFile caches its callables. Compare the callables directly instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
TwitchBronBron
marked this pull request as ready for review
October 5, 2026 18:35
TwitchBronBron
enabled auto-merge (squash)
October 5, 2026 18:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duplicate-function diagnostic skips "itself" when listing the other declarations by comparing
nameRangeobjects by reference. That only works becauseBrsFilecaches its callables, and it would quietly break if the ranges were ever rebuilt (as they are once locations are computed on demand in #1845). Compare the callables directly instead.Verified with
npm run test:nocover. The new test passes onv1either way; it guards the behavior.🤖 Generated with Claude Code