Repository navigation
Rename Locatable props to startPosition, endPosition and sourceInfo - #1918
Merged
Merged
Conversation
`source` collided with other fields that mean something else (LSP `Diagnostic.source`, plugin RawCodeStatement `source` strings), which broke the `'source' in x` checks, and `pos` only named the start. `SourceInfo.lineStarts` is now `linePositions`. Done with the TypeScript language service rename, plus the string checks, untyped test literals, comments and docs it can't see. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1845.
sourcecollided with fields that mean something else (LSPDiagnostic.source, thesourcestrings on plugin RawCodeStatements), so the'source' in xchecks could misfire. Andposonly named the start of the pair.pos→startPosition,end→endPosition,source→sourceInfoonLocatable,AstNode,TokenObjectand every node classSourceInfo.lineStarts→linePositions'source' in xchecks →'sourceInfo' in x🤖 Generated with Claude Code