Repository navigation
Conversation
Collaborator
|
Change this to work on the v1 branch |
CG-5228
force-pushed
the
oss-agent/issue-776
branch
from
October 16, 2026 23:10
1a0a90c to
434bd63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #776
Root Cause:
DiagnosticFiltererpreviously only supported filtering diagnostics by file glob (src) and diagnosticcodes, without a mechanism to filter by diagnostic severity (error,warn,info,hint).Fix: Added support for severity-based diagnostic filtering (severities and severity in diagnosticFilters) in src/BsConfig.ts, bsconfig.schema.json, and src/DiagnosticFilterer.ts with canonical normalization in getDiagnosticFilters, documented combined codes+severities union (OR) and negative-glob precedence semantics, updated docs/bsconfig.md with examples, and added unit tests in src/DiagnosticFilterer.spec.ts.
Files Modified
bsconfig.schema.jsondocs/bsconfig.mdsrc/BsConfig.tssrc/DiagnosticFilterer.spec.tssrc/DiagnosticFilterer.tsVerification Performed (Isolated Container Sandbox)
256b28083527ba512535a4ddc7164c8def24ecd4node:22-alpine(--network none --read-only --cap-drop ALL)npm run test:nocover && npm run lint && npm run build