Refactor async_context_manager type annotations using ParamSpec - #828
Open
junyilou wants to merge 1 commit into
Open
Refactor async_context_manager type annotations using ParamSpec#828junyilou wants to merge 1 commit into
async_context_manager type annotations using ParamSpec#828junyilou wants to merge 1 commit into
Conversation
Updated async_context_manager function to use ParamSpec for better type hinting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the type annotations for the
async_context_managerdecorator inasyncssh/misc.pyby replacingCallable[..., ...]withParamSpec(_ACMParam). By capturing parameter types withParamSpec, static analysis tools and IDEs now accurately inspect and auto-complete the original function's arguments (names, types, and defaults) when calling decorated functions, significantly improving type safety and developer experience.typing.ParamSpecwas introduced in Python 3.10, which aligns with the project's target Python version.