Repository navigation
fix: place the Switch thumb by its center, as MD3 does - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Switch thumb kept its start edge fixed. MD3 places the thumb by its center, so the off thumb sat too close to the edge, and a press grew it toward the end only. This PR places the thumb by its center.
Changes
unselectedIcon, 16 off. Before, two springs added their undershoots, and the thumb shrank to 13.3 dp at the end of a toggle off.Test plan
Switch.test.tsxfail when the old offset is put backpnpm run testandpnpm run build(CI)Screenshots
Left: before. Right: after. Rows: off at rest, pressed while on, end of a toggle off.