Fix sequential and non-interactive terminal resize replay - #138
Open
r-sandeep wants to merge 3 commits into
Open
Fix sequential and non-interactive terminal resize replay#138r-sandeep wants to merge 3 commits into
r-sandeep wants to merge 3 commits into
Conversation
added 3 commits
August 24, 2026 01:22
… in js/terminal-ext.js with focused regressions in tests/terminal-ext.test.js; replay now awaits deep links and
…terminal-ext.js and added focused regressions in tests/terminal-ext.test.js so replay now awaits deep links and
…rminal-ext.js and added focused regressions in tests/terminal-ext.test.js, including the missing deferred async
r-sandeep
marked this pull request as ready for review
August 26, 2026 01:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix terminal transcript restoration after resize so replay is sequential, non-interactive, and busy-owned for its full duration.
Changes
term.busytrue throughout replay and restore replay state in cleanupapplyand animatedupgradehistory lines without re-running their side effectsScope
Only the requested files are changed:
js/terminal-ext.jstests/terminal-ext.test.jsNo dependencies were added.
Validation
npm test— passed: 7 test files, 128 testsnpm run build— passedBoth canonical commands also passed in clean-checkout validation on the reviewed repository state.
Approvals and review
ASD references
workflow_run_42e4928e9c524260a2312e43d97a5a3atask_e8fcae1a7570437ab079659ada789b9cprepare_outcome_deliveryenterprise_bug_fix_council_v1